Hi Dominik, for general V8 contribution guidelines, please follow https://v8.dev/docs/contribute. There is also currently some work going regarding stack traces. Feel free to use the same tracking bug ( https://crbug.com/v8/8742) for your CLs. You can send your CLs to me for review and I will add additional reviewers as necessary.
AFAIK Node 12 will stay at V8 API compatibility of 7.5 (the current V8 version being worked on is 7.6). Meaning your change won't make it into Node 12. Note that the contribution process for Node itself differs from V8. Cheers, Simon *From: *Jakob Gruber <[email protected]> *Date: *Thu, May 16, 2019 at 2:01 PM *To: * <[email protected]>, Simon Zünd, Yang Guo +Simon Zünd <[email protected]> +Yang Guo <[email protected]> > > *From: *Dominik Gruber <[email protected]> > *Date: *Thu, May 16, 2019 at 1:58 PM > *To: *v8-dev > > Dear v8 community, >> >> Background: The native API is lacking the functionality "GetTypeName" on >> StackFrame objects contrary to Callsites where this feature is available to >> the managed API. >> >> We have implemented and tested this feature with Nodejs and would like to >> contribute those changes to the v8 source and get that feature into Nodejs >> as soon as possible. >> >> Can someone guide me through the contribution process regarding issue >> creation, code review, merge to Nodejs? >> >> Thanks, >> Dominik >> >> >> >> >> >> >> >> >> -- >> -- >> v8-dev mailing list >> [email protected] >> http://groups.google.com/group/v8-dev >> --- >> You received this message because you are subscribed to the Google Groups >> "v8-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/v8-dev/7b6bdc89-ec2f-4594-8c4f-7b7af4b426d2%40googlegroups.com >> <https://groups.google.com/d/msgid/v8-dev/7b6bdc89-ec2f-4594-8c4f-7b7af4b426d2%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CACswSC2j%2BsV9HZ7OM-LJ8xPxOJW1-Z5g4jyqGhAzMmHaq2hgFQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
