I think additive changes to V8's API are fine. E.g. adding a new API does not break native modules compiled against a version of V8 that does not yet have that new API.
Cheers, Yang Yang Guo | Google Germany GmbH | Erika-Mann-Str. 33 | 80636 München Geschäftsführer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind, leiten Sie diese bitte nicht weiter, informieren Sie den Absender und löschen Sie die E-Mail und alle Anhänge. Vielen Dank. This e-mail is confidential. If you are not the right addressee please do not forward it, please inform the sender, and please erase this e-mail including any attachments. Thanks. On Thu, May 16, 2019 at 2:10 PM Simon Zünd <szu...@google.com> wrote: > Hi Dominik, > > for general V8 contribution guidelines, please follow > https://v8.dev/docs/contribute. There is also currently some work going > regarding stack traces. Feel free to use the same tracking bug ( > https://crbug.com/v8/8742) for your CLs. You can send your CLs to me for > review and I will add additional reviewers as necessary. > > AFAIK Node 12 will stay at V8 API compatibility of 7.5 (the current V8 > version being worked on is 7.6). Meaning your change won't make it into > Node 12. Note that the contribution process for Node itself differs from V8. > > Cheers, > Simon > > *From: *Jakob Gruber <jgru...@chromium.org> > *Date: *Thu, May 16, 2019 at 2:01 PM > *To: * <v8-dev@googlegroups.com>, Simon Zünd, Yang Guo > > +Simon Zünd <szu...@google.com> +Yang Guo <yang...@google.com> >> >> *From: *Dominik Gruber <dominik.gru...@dynatrace.com> >> *Date: *Thu, May 16, 2019 at 1:58 PM >> *To: *v8-dev >> >> Dear v8 community, >>> >>> Background: The native API is lacking the functionality "GetTypeName" on >>> StackFrame objects contrary to Callsites where this feature is available to >>> the managed API. >>> >>> We have implemented and tested this feature with Nodejs and would like >>> to contribute those changes to the v8 source and get that feature into >>> Nodejs as soon as possible. >>> >>> Can someone guide me through the contribution process regarding issue >>> creation, code review, merge to Nodejs? >>> >>> Thanks, >>> Dominik >>> >>> >>> >>> >>> >>> >>> >>> >>> -- >>> -- >>> v8-dev mailing list >>> v8-dev@googlegroups.com >>> http://groups.google.com/group/v8-dev >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "v8-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to v8-dev+unsubscr...@googlegroups.com. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/v8-dev/7b6bdc89-ec2f-4594-8c4f-7b7af4b426d2%40googlegroups.com >>> <https://groups.google.com/d/msgid/v8-dev/7b6bdc89-ec2f-4594-8c4f-7b7af4b426d2%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAFSTc_idXkifk_vcQea%2Bsm%3DR9DKM%2Bv8Hr6KzR2y%3D%2BFKX2o7_yg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
