On Thu, May 16, 2019 at 2:10 PM 'Simon Zünd' via v8-dev <v8-dev@googlegroups.com> wrote: > AFAIK Node 12 will stay at V8 API compatibility of 7.5 (the current V8 > version being worked on is 7.6). Meaning your change won't make it into Node > 12. Note that the contribution process for Node itself differs from V8.
Additive V8 changes are acceptable in Node.js provided they've been merged in upstream V8 first and API and ABI are maintained. A new, non-virtual `StackFrame::GetTypeName()` method should be no problem and could land in a minor v12.x release. @Dominik: https://github.com/nodejs/node/pull/27729 is an example of cherry-picking a patch from upstream. Target the master branch, releasers will take care of back-porting it to release branches. -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAHQurc8zVeg3XhJ9iN8NHmQMz7kz8P0tN2-D3pJBb-D2TBYoOg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.