Unfortunately we don't accept patches from Github PRs and we don't review code on Github. Please follow the instructions at https://chromium.googlesource.com/chromium/src/+/master/docs/contributing.md#Uploading-a-change-for-review. This way, the CL can run against our Try bots and the CL can properly be reviewed in Gerrit.
On Mon, May 20, 2019 at 1:25 PM Dominik Gruber <dominik.gru...@dynatrace.com> wrote: > Hi Simon, > > Dynatrace has already signed the CLA. > I am currently porting the changeset to our v8 fork. Is it sufficient if I > provide the link to the git repo with the changelist for reviewing? > > Thanks, > Dominik > > > On Thursday, May 16, 2019 at 2:10:09 PM UTC+2, Simon Zünd wrote: >> >> Hi Dominik, >> >> for general V8 contribution guidelines, please follow >> https://v8.dev/docs/contribute. There is also currently some work going >> regarding stack traces. Feel free to use the same tracking bug ( >> https://crbug.com/v8/8742) for your CLs. You can send your CLs to me for >> review and I will add additional reviewers as necessary. >> >> AFAIK Node 12 will stay at V8 API compatibility of 7.5 (the current V8 >> version being worked on is 7.6). Meaning your change won't make it into >> Node 12. Note that the contribution process for Node itself differs from V8. >> >> Cheers, >> Simon >> >> *From: *Jakob Gruber <jgr...@chromium.org> >> *Date: *Thu, May 16, 2019 at 2:01 PM >> *To: * <v8-...@googlegroups.com>, Simon Zünd, Yang Guo >> >> +Simon Zünd +Yang Guo >>> >>> *From: *Dominik Gruber <domini...@dynatrace.com> >>> *Date: *Thu, May 16, 2019 at 1:58 PM >>> *To: *v8-dev >>> >>> Dear v8 community, >>>> >>>> Background: The native API is lacking the functionality "GetTypeName" >>>> on StackFrame objects contrary to Callsites where this feature is available >>>> to the managed API. >>>> >>>> We have implemented and tested this feature with Nodejs and would like >>>> to contribute those changes to the v8 source and get that feature into >>>> Nodejs as soon as possible. >>>> >>>> Can someone guide me through the contribution process regarding issue >>>> creation, code review, merge to Nodejs? >>>> >>>> Thanks, >>>> Dominik >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> -- >>>> -- >>>> v8-dev mailing list >>>> v8-...@googlegroups.com >>>> http://groups.google.com/group/v8-dev >>>> --- >>>> You received this message because you are subscribed to the Google >>>> Groups "v8-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to v8-...@googlegroups.com. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/v8-dev/7b6bdc89-ec2f-4594-8c4f-7b7af4b426d2%40googlegroups.com >>>> <https://groups.google.com/d/msgid/v8-dev/7b6bdc89-ec2f-4594-8c4f-7b7af4b426d2%40googlegroups.com?utm_medium=email&utm_source=footer> >>>> . >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> -- > -- > v8-dev mailing list > v8-dev@googlegroups.com > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to v8-dev+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/v8-dev/2eecbe69-7b7d-42f5-8437-f4fe7a2b1158%40googlegroups.com > <https://groups.google.com/d/msgid/v8-dev/2eecbe69-7b7d-42f5-8437-f4fe7a2b1158%40googlegroups.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CACswSC023xdUUuhhV_oNyWipYWq2FAOoZV-1DLN6x8T%3Dnb0T5A%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
