Lasse, may you have another look?
http://codereview.chromium.org/1780001/diff/1/3 File src/heap.cc (right): http://codereview.chromium.org/1780001/diff/1/3#newcode548 src/heap.cc:548: if (context == NULL) return; On 2010/04/26 10:04:55, Lasse Reichstein wrote:
Are Result-caches per-context yet?
As of time when I uploaded this CL they were not in yet. Now they are submitted. I am going to rebaseline and maybe start another review.
If so, isn't this only clearing the currently active context? I am expecting to see an operation on the sleeping threads as well
somewhere -
preferably in a gc_prologue like the other cache flushes.
Ok. http://codereview.chromium.org/1780001/diff/1/5 File src/objects-inl.h (right): http://codereview.chromium.org/1780001/diff/1/5#newcode573 src/objects-inl.h:573: return IsFixedArray(); On 2010/04/26 10:04:55, Lasse Reichstein wrote:
Also check that the length is correct (at least kEntriesIndex plus
something
even).
Done http://codereview.chromium.org/1780001/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
