Still LGTM.

http://codereview.chromium.org/1780001/diff/11001/12007
File test/cctest/test-threads.cc (right):

http://codereview.chromium.org/1780001/diff/11001/12007#newcode65
test/cctest/test-threads.cc:65: first_section_->Lock();
I'm not sure how Mutex'es work. Can you lock them in one thread and
release them in another? If so, this seems fine.

http://codereview.chromium.org/1780001/diff/11001/12007#newcode88
test/cctest/test-threads.cc:88: // Release acuired lock.
typo: acuired->acquired.

http://codereview.chromium.org/1780001/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to