Thanks a lot for review, Lasse.
http://codereview.chromium.org/1780001/diff/6001/7004 File src/objects-inl.h (right): http://codereview.chromium.org/1780001/diff/6001/7004#newcode575 src/objects-inl.h:575: return ((self->length() - JSFunctionResultCache::kEntriesIndex) On 2010/05/04 13:40:39, Lasse Reichstein wrote:
I wouldn't add it to HeapObjectVerify. It's not a property of the
heap-object
that can be checked independently of its use. Being a function cache
is only a
role for a FixedArray, not an identity, so a heap iterator wouldn't be
able to
use it for anything.
Thanks. http://codereview.chromium.org/1780001/diff/11001/12006 File src/objects.h (right): http://codereview.chromium.org/1780001/diff/11001/12006#newcode2336 src/objects.h:2336: void JSFunctionResultCacheVerfiy(); On 2010/05/04 13:40:40, Lasse Reichstein wrote:
Typo: Verfiy->Verify.
Thanks, fixed. http://codereview.chromium.org/1780001/diff/11001/12007 File test/cctest/test-threads.cc (right): http://codereview.chromium.org/1780001/diff/11001/12007#newcode65 test/cctest/test-threads.cc:65: first_section_->Lock(); On 2010/05/04 13:50:35, Lasse Reichstein wrote:
I'm not sure how Mutex'es work. Can you lock them in one thread and
release them
in another? If so, this seems fine.
I think you noticed a real problem---the test doesn't run as I expect it. I reworked it. I'll ask Erik to have a look and would appreciate if you have a look as well, but for now I am going to submit this CL. http://codereview.chromium.org/1780001/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
