LGTM.
http://codereview.chromium.org/1780001/diff/6001/7004 File src/objects-inl.h (right): http://codereview.chromium.org/1780001/diff/6001/7004#newcode575 src/objects-inl.h:575: return ((self->length() - JSFunctionResultCache::kEntriesIndex) I wouldn't add it to HeapObjectVerify. It's not a property of the heap-object that can be checked independently of its use. Being a function cache is only a role for a FixedArray, not an identity, so a heap iterator wouldn't be able to use it for anything. http://codereview.chromium.org/1780001/diff/11001/12006 File src/objects.h (right): http://codereview.chromium.org/1780001/diff/11001/12006#newcode2336 src/objects.h:2336: void JSFunctionResultCacheVerfiy(); Typo: Verfiy->Verify. http://codereview.chromium.org/1780001/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
