http://codereview.chromium.org/1780001/diff/1/3 File src/heap.cc (right):
http://codereview.chromium.org/1780001/diff/1/3#newcode548 src/heap.cc:548: if (context == NULL) return; Are Result-caches per-context yet? If so, isn't this only clearing the currently active context? I am expecting to see an operation on the sleeping threads as well somewhere - preferably in a gc_prologue like the other cache flushes. http://codereview.chromium.org/1780001/diff/1/5 File src/objects-inl.h (right): http://codereview.chromium.org/1780001/diff/1/5#newcode573 src/objects-inl.h:573: return IsFixedArray(); Also check that the length is correct (at least kEntriesIndex plus something even). http://codereview.chromium.org/1780001/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
