Getting very close.
https://codereview.chromium.org/23480031/diff/97001/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
https://codereview.chromium.org/23480031/diff/97001/src/ia32/full-codegen-ia32.cc#newcode171
src/ia32/full-codegen-ia32.cc:171: __ nop();
Use __ Nop(padding_size) here, lithium and on x64.
https://codereview.chromium.org/23480031/diff/97001/src/v8globals.h
File src/v8globals.h (right):
https://codereview.chromium.org/23480031/diff/97001/src/v8globals.h#newcode216
src/v8globals.h:216: static const int kPrologueOffsetNotSet = -1;
This is probably better suited to be in codegen.h
https://codereview.chromium.org/23480031/diff/97001/src/x64/full-codegen-x64.cc
File src/x64/full-codegen-x64.cc (right):
https://codereview.chromium.org/23480031/diff/97001/src/x64/full-codegen-x64.cc#newcode209
src/x64/full-codegen-x64.cc:209:
nit: remove whitespace change
https://codereview.chromium.org/23480031/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
