https://codereview.chromium.org/23480031/diff/97001/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
https://codereview.chromium.org/23480031/diff/97001/src/ia32/full-codegen-ia32.cc#newcode171
src/ia32/full-codegen-ia32.cc:171: __ nop();
On 2013/10/04 16:30:09, danno wrote:
Use __ Nop(padding_size) here, lithium and on x64.
Done. Also cleaned up codegen::PatchCodeAge.
https://codereview.chromium.org/23480031/diff/97001/src/v8globals.h
File src/v8globals.h (right):
https://codereview.chromium.org/23480031/diff/97001/src/v8globals.h#newcode216
src/v8globals.h:216: static const int kPrologueOffsetNotSet = -1;
On 2013/10/04 16:30:09, danno wrote:
This is probably better suited to be in codegen.h
It is needed in a number of .h files (heap.h, factory.h, etc). If I move
this to codegen.h I need to add codegen.h to these headers includes,
which seems to cause a bunch of compile errors - e.g.:
In file included from ../src/gdb-jit.h:41:0,
from ../src/assembler.h:42,
from ../src/code-stubs.h:32,
from ../src/codegen.h:31,
from ../src/heap.h:35,
from ../src/elements.h:33,
from ../src/objects-inl.h:38,
from ../src/v8.h:61,
from ../src/accessors.cc:28:
../src/factory.h:460:13: error: ‘ROOT_ACCESSOR’ has not been declared
../src/factory.h:460:26: error: ISO C++ forbids declaration of
‘ROOT_LIST’ with no type [-fpermissive]
Any ideas on how to solve this?
https://codereview.chromium.org/23480031/diff/97001/src/x64/full-codegen-x64.cc
File src/x64/full-codegen-x64.cc (right):
https://codereview.chromium.org/23480031/diff/97001/src/x64/full-codegen-x64.cc#newcode209
src/x64/full-codegen-x64.cc:209:
On 2013/10/04 16:30:09, danno wrote:
nit: remove whitespace change
Done.
https://codereview.chromium.org/23480031/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
