Almost there, sorry, one comment on your last change.
https://codereview.chromium.org/23480031/diff/117001/src/ia32/macro-assembler-ia32.h
File src/ia32/macro-assembler-ia32.h (right):
https://codereview.chromium.org/23480031/diff/117001/src/ia32/macro-assembler-ia32.h#newcode229
src/ia32/macro-assembler-ia32.h:229: void Prologue(bool is_stub);
Here and other platforms: Can you please use an enum, e.g.
enum PrologueFrameMode {
BUILD_STUB_FRAME,
BUILD_OPTIMIZED_FRAME
}
or something to that effect.
https://codereview.chromium.org/23480031/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
