On 2013/10/15 17:03:43, rmcilroy wrote:
On 2013/10/14 18:53:14, danno wrote:
> Can you try making this:
>
> static const int kPrologueOffsetNotSet = -1;
>
> a public static memory of Code in objects.h? That's better than
v8globals.h
Good plan. Done.
https://codereview.chromium.org/23480031/diff/109001/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):
https://codereview.chromium.org/23480031/diff/109001/src/arm/full-codegen-arm.cc#newcode167
src/arm/full-codegen-arm.cc:167: PredictableCodeSizeScope
predictible_code_size_scope(
On 2013/10/14 18:53:14, danno wrote:
> For this and other platforms, can you please consolidate the logic for
emitting
> the prologue into the macros assembler? Everything from
PredictableCodeSizeScope
> to the end of your change is the same for full codegen and crankshaft.
You
will
> probably need a single parameter "for_generated_stub" to distinguish the
> JSFunction pointer.
Done.
Ping?
https://codereview.chromium.org/23480031/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
