https://codereview.chromium.org/121173009/diff/1/src/unicode.h#newcode158
src/unicode.h:158: static inline unsigned Encode(char* str, uchar c, bool
replace_surrogates);
On 2014/01/04 15:56:45, dcarney wrote:
> this is not backwards compatible.
Is there a good reason to keep compatibility, rather than changing the
call
sites?
By compatibility, I just mean the current behaviour must be maintained.
You can
change the call sites, but they will all have to be changed to maintain the
current invalid encoding rules. That would be fine, but it's a bit odd to
have
to push this logic out into various places. It would seem more sensible to
somehow encapsulate what you're trying to do in unicode.*, rather than in
api.cc.
https://codereview.chromium.org/121173009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
