https://codereview.chromium.org/121173009/diff/130001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/121173009/diff/130001/src/api.cc#newcode4523
src/api.cc:4523: static int WritePair(uint16_t current,
WritePair is a bad name here, since it may or not be a pair.
https://codereview.chromium.org/121173009/diff/130001/src/api.cc#newcode4556
src/api.cc:4556: int written = WritePair(current,
this is not a surrogate pair, could use Encode directly
https://codereview.chromium.org/121173009/diff/130001/src/unicode-inl.h
File src/unicode-inl.h (right):
https://codereview.chromium.org/121173009/diff/130001/src/unicode-inl.h#newcode115
src/unicode-inl.h:115: if (!allow_invalid &&
move this block down into the kMaxThreeByteChar clause. it's in the way
of the common case
https://codereview.chromium.org/121173009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
