My latest patch:
* Fixes the missing default value in the header (sorry, I'm not used to
working
with header files, so I keep forgetting : /, wish the compiler told me
about it)
* Fixes the funny formatting
* Renames allow to replace, as it's more descriptive
* Adds a test case for the buffer limit being hit on a lead surrogate
* Adds a fix attempt for the issue, but it's not working yet (I think I can
figure it out, I need more time)
* Documents the Utf8WriterVisitor Visit method as I found it to be quite
complex. I hope you want to keep it, but no worries if not.
I have to wrap things up for today and thought it can't hurt to send out the
latest progress. However, feel free to ignore this patch set until I can
figure
out how to fix the lead surrogate at the end of buffer edge case.
https://codereview.chromium.org/121173009/diff/300001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/121173009/diff/300001/include/v8.h#newcode1652
include/v8.h:1652: // @TODO Rename to REPLACE_INVALID_UTF8?
On 2014/01/13 09:19:56, dcarney wrote:
sure
Done.
https://codereview.chromium.org/121173009/diff/300001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/121173009/diff/300001/src/api.cc#newcode4709
src/api.cc:4709: capacity /
static_cast<int>(unibrow::Utf8::kMax16BitCodeUnitSize)
On 2014/01/13 09:19:56, dcarney wrote:
this formatting is funny
either use clang format or move the constant above the if statement to
make it
shorter
Done.
https://codereview.chromium.org/121173009/diff/300001/src/unicode-inl.h
File src/unicode-inl.h (right):
https://codereview.chromium.org/121173009/diff/300001/src/unicode-inl.h#newcode116
src/unicode-inl.h:116: bool allow_invalid = true) {
On 2014/01/13 09:19:56, dcarney wrote:
default should be in declaration
Done.
https://codereview.chromium.org/121173009/diff/300001/src/unicode.h
File src/unicode.h (right):
https://codereview.chromium.org/121173009/diff/300001/src/unicode.h#newcode155
src/unicode.h:155: bool allow_invalid);
On 2014/01/13 09:19:56, dcarney wrote:
needs default value
Done.
https://codereview.chromium.org/121173009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
