I'll maintain current behavior throughout the system. I agree that my
patch
can
be done without changing the semantics of Utf8::Encode. However making
Utf8::Encode more modular has been very useful to my ability to reason
about
the
system, so I'd like to continue going into this direction.
The direction is fine, it's just that you need to maintain state
(should_replace_characters, last_character, etc) in some kind of uniform
way. I
think some sort of class in unicode.h is the place to put it.
https://codereview.chromium.org/121173009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
