On Fri, 24 Apr 2026 06:34:31 GMT, Christian Hagedorn <[email protected]> 
wrote:

> I did a pass over the compiler code and cleaned up some code. This including:
> - Unused variables
> - Unused includes
> - Make methods `const/static`
> - Adding `override`
> - Fix code style
> - Rename variables that hide outer scope variables
> - Remove unused code
> - Remove line breaks not present in mainline
> 
> More details in PR comments.
> 
> I did some sanity testing up to tier4 + stress.
> 
> Thanks,
> Christian
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Marked as reviewed by mchevalier (Committer).

That's the kind of changes I like!

src/hotspot/share/ci/ciRefArrayKlass.hpp line 48:

> 46: 
> 47:   ciKlass* exact_klass() override {
> 48:     return this;

Is it worth putting that on a single line, like the other methods above?

-------------

PR Review: 
https://git.openjdk.org/valhalla/pull/2364#pullrequestreview-4168582418
PR Comment: https://git.openjdk.org/valhalla/pull/2364#issuecomment-4311358606
PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2364#discussion_r3136041875

Reply via email to