On Fri, 24 Apr 2026 06:50:02 GMT, Christian Hagedorn <[email protected]> wrote:
>> I did a pass over the compiler code and cleaned up some code. This including: >> - Unused variables >> - Unused includes >> - Make methods `const/static` >> - Adding `override` >> - Fix code style >> - Rename variables that hide outer scope variables >> - Remove unused code >> - Remove line breaks not present in mainline >> >> More details in PR comments. >> >> I did some sanity testing up to tier4 + stress. >> >> Thanks, >> Christian >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > src/hotspot/share/opto/inlinetypenode.cpp line 1465: > >> 1463: if (!field->is_null_free()) { >> 1464: assert(field->null_marker_offset() != -1, "inconsistency"); >> 1465: Node* null_marker = nullptr; > > Hides outer-scope `null_marker` variable. Renamed. Alright... But I don't think shadowing is bad at all. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2364#discussion_r3136050655
