On Fri, 24 Apr 2026 07:12:40 GMT, Marc Chevalier <[email protected]> wrote:
>> src/hotspot/share/opto/inlinetypenode.cpp line 1465:
>>
>>> 1463: if (!field->is_null_free()) {
>>> 1464: assert(field->null_marker_offset() != -1, "inconsistency");
>>> 1465: Node* null_marker = nullptr;
>>
>> Hides outer-scope `null_marker` variable. Renamed.
>
> Alright... But I don't think shadowing is bad at all.
I think it depends. The IDE marks it with a warning. Sometimes it can be
misleading when you look at the wrong definition or you want to assign actually
to the outer-scope variable but miss that it's being shadowed at the moment.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2364#discussion_r3137320022
