On Fri, 24 Apr 2026 06:43:05 GMT, Christian Hagedorn <[email protected]> wrote:
>> I did a pass over the compiler code and cleaned up some code. This including: >> - Unused variables >> - Unused includes >> - Make methods `const/static` >> - Adding `override` >> - Fix code style >> - Rename variables that hide outer scope variables >> - Remove unused code >> - Remove line breaks not present in mainline >> >> More details in PR comments. >> >> I did some sanity testing up to tier4 + stress. >> >> Thanks, >> Christian >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > src/hotspot/share/opto/callGenerator.cpp line 188: > >> 186: if (kit.stopped()) { >> 187: return kit.transfer_exceptions_into_jvms(); >> 188: } > > This and the same below were added with [this > commit](https://github.com/openjdk/valhalla/commit/9de8ea4d7d75d36d21707e26c062a4cfaf5fc17a#diff-be12257b7cfa0ec96698a5c3958f5aa98723582f68cf2648b376bbe40576b52d) > when inserting an uncommon trap to `set_arguments_for_java_call()`: > https://github.com/openjdk/valhalla/blob/9de8ea4d7d75d36d21707e26c062a4cfaf5fc17a/src/hotspot/share/opto/graphKit.cpp#L1806 > > The trap was later removed with JDK-8212190 again which makes the `stopped()` > call unneeded: > https://github.com/openjdk/valhalla/commit/0a07ea9ba9a6ae110e4874c8bd75f144a5b0a647#diff-be12257b7cfa0ec96698a5c3958f5aa98723582f68cf2648b376bbe40576b52d > > I removed both checks. Uh, good catch. How did you spot this? ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2364#discussion_r3136052142
