On Fri, 24 Apr 2026 07:12:57 GMT, Tobias Hartmann <[email protected]> wrote:
>> src/hotspot/share/opto/callGenerator.cpp line 188:
>>
>>> 186: if (kit.stopped()) {
>>> 187: return kit.transfer_exceptions_into_jvms();
>>> 188: }
>>
>> This and the same below were added with [this
>> commit](https://github.com/openjdk/valhalla/commit/9de8ea4d7d75d36d21707e26c062a4cfaf5fc17a#diff-be12257b7cfa0ec96698a5c3958f5aa98723582f68cf2648b376bbe40576b52d)
>> when inserting an uncommon trap to `set_arguments_for_java_call()`:
>> https://github.com/openjdk/valhalla/blob/9de8ea4d7d75d36d21707e26c062a4cfaf5fc17a/src/hotspot/share/opto/graphKit.cpp#L1806
>>
>> The trap was later removed with JDK-8212190 again which makes the
>> `stopped()` call unneeded:
>> https://github.com/openjdk/valhalla/commit/0a07ea9ba9a6ae110e4874c8bd75f144a5b0a647#diff-be12257b7cfa0ec96698a5c3958f5aa98723582f68cf2648b376bbe40576b52d
>>
>> I removed both checks.
>
> Uh, good catch. How did you spot this?
Thanks :-) I was debugging some code in `set_arguments_for_java_call()` as part
of another bug and wondered where we would actually call `stop()` and then dug
deeper.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2364#discussion_r3137320326
