On Mon, 27 Apr 2026 16:57:58 GMT, Axel Boldt-Christmas <[email protected]> wrote:
>> Frederic Parain has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Silently skip the test when flattening conditions are not satisfied >> - Add argument and CDS validation of the new VM option > > src/hotspot/share/runtime/globals.hpp line 837: > >> 835: product(intx, FlatteningBudget, 1024, >> \ >> 836: "Maximum size dedicated to flat fields in an instance") >> \ >> 837: range(0, 1024 * 1024) >> \ > > Should this be part of the `DISABLE_FLAG_AND_WARN_IF_NOT_DEFAULT` type > mechanism ? > > Also I have not digged to deep into AOT / CDS. But it seems like this > property should be stable from dump and load. `CDS_MUST_MATCH_FLAGS_DO`. > However this might limit things to much. But I am guess if this flag affected > layout decisions between dump and run, things would not work. Good point. The new VM option has an impact on flattening decisions, so it must match the value use to generate the CDS archive. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2372#discussion_r3149813705
