On Mon, 27 Apr 2026 16:55:27 GMT, Axel Boldt-Christmas <[email protected]> wrote:
>> Frederic Parain has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Silently skip the test when flattening conditions are not satisfied >> - Add argument and CDS validation of the new VM option > > test/hotspot/jtreg/runtime/valhalla/inlinetypes/TestFlatteningBudget.java > line 31: > >> 29: * @library /test/lib >> 30: * @enablePreview >> 31: * @run main runtime.valhalla.inlinetypes.TestFlatteningBudget > > Should this be a driver tests as it creates new instances for the each test? > > Not sure if this test should be flagless as it assumes it does not get in > external flags that disable flattening. Alternatively have main method do a > quick test for flattening, then throw a skipped exception if fields are not > flattened as expected. > > Maybe there is already some shared test utility for doing this sort of thing. The `--enable-preview` is not passed to the test when run in `driver` mode, causing the test to fail to execute. Logic has been added to the test to silently skip the test if the flattening conditions are not satisfied ( in such case, a message is printed on the output and recorded in the .jtr file) ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2372#discussion_r3149838987
