On Tue, 28 Apr 2026 11:13:32 GMT, Paul Hübner <[email protected]> wrote:
>> Frederic Parain has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Silently skip the test when flattening conditions are not satisfied >> - Add argument and CDS validation of the new VM option > > src/hotspot/share/runtime/globals.hpp line 835: > >> 833: "before no flattening attempts are made, <0 indicates no >> limit") \ >> 834: >> \ >> 835: product(intx, FlatteningBudget, 1024, >> \ > > The flag should be diagnostic to be consistent. Flags such as > `UseArrayFlattening` are set to diagnostic. I don't think this is more > "important" than `UseArrayFlattening`. Let me know if you disagree. Disabling array flattening is a diagnostic feature to investigate if a particular issue is related to array flattening. The FlatteningBudget is different, it's a sizing parameter that some applications need to change, not because someone is investigating an issue, but because the design of the application's classes would not be allow them to be flatten otherwise. It's a flag that makes sense in production, not necessarily in a troubleshooting situtation. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2372#discussion_r3161566329
