On Tue, 28 Apr 2026 11:19:49 GMT, Paul Hübner <[email protected]> wrote:
>> Frederic Parain has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Silently skip the test when flattening conditions are not satisfied
>> - Add argument and CDS validation of the new VM option
>
> test/hotspot/jtreg/runtime/valhalla/inlinetypes/TestFlatteningBudget.java
> line 111:
>
>> 109: // Test cannot work properly if field flattening is disabled
>> 110: if (!useFieldFlattening) {
>> 111: System.out.println("Test skipped because field flattening
>> is disabled");
>
> The "proper" way of doing this is by throwing a `SkippedException`.
It would be nicer to do this through jtreg though. You can make a `@requires`
where you can check if they're (a) set explicitly, and/or (b) the expected
boolean value. See this example:
https://github.com/openjdk/jdk/pull/29848/changes
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2372#discussion_r3153673737
