On Tue, 28 Apr 2026 04:21:36 GMT, Axel Boldt-Christmas <[email protected]> wrote:
>> Once you have a flattening budget, doesn't this bring up issues similar to >> method inlining on how to spend that budget? For example, should it be >> spent eagerly on the first fields (depth first), or should top-level fields >> be flattened before nested fields (breadth first)? > >> Once you have a flattening budget, doesn't this bring up issues similar to >> method inlining on how to spend that budget? For example, should it be spent >> eagerly on the first fields (depth first), or should top-level fields be >> flattened before nested fields (breadth first)? > > I was thinking the same, but more along the lines of a bytes utilization > knapsack problem. We probably don’t have any information about what is good > to flatten unless we add something to the AOT training data. > > But feels like it would add a whole lot of complexity, and seems like a post > 401 RFE. Thanks @xmas92 @Arraying for the reviews. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/2372#issuecomment-4388442459
