On Tue, 2 Jun 2026 15:02:38 GMT, Matias Saavedra Silva <[email protected]> wrote:
>> Classes can be excluded from the CDS archive for a variety of different >> reasons, such as having old classfile versions or being stored in a signed >> jar. These exclusions can extend to other classes that depend on an excluded >> class such as supers or interfaces. >> >> Flat and null-restricted fields have layouts that are calculated when a >> classfile is parsed and they rely on the klass of the field being consistent >> between dumptime and runtime, thus adding a new dependency. This patch adds >> inline flat and null-restricted fields as new dependencies that may lead to >> the holding class being excluded from the CDS archive. Verified with a new >> test and tier 1-5 tests. >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Matias Saavedra Silva has updated the pull request incrementally with one > additional commit since the last revision: > > Ioi comments src/hotspot/share/classfile/systemDictionaryShared.cpp line 305: > 303: // To ensure this, the types of the fields must be stored in the > archive along with > 304: // the field holder. > 305: if (k->has_inlined_fields()) { @fparain were you expecting to see an updated `if` statement with two conditions here? if (k->has_inlined_fields() || k->has_null_restricted_static_fields()) {...} ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2464#discussion_r3343721347
