On Tue, 2 Jun 2026 19:52:51 GMT, Coleen Phillimore <[email protected]> wrote:
>> Matias Saavedra Silva has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Ioi comments
>
> src/hotspot/share/classfile/classFileParser.cpp line 6336:
>
>> 6334: // the array of InlineLayoutInfo since it isn't needed, and so it
>> isn't
>> 6335: // transferred to the allocated InstanceKlass.
>> 6336: if (_inline_layout_info_array != nullptr &&
>> !(_layout_info->_has_inlined_fields || _has_null_restricted_static_fields)) {
>
> Suggestion:
>
> if (_inline_layout_info_array != nullptr &&
> !_layout_info->_has_inlined_fields && !_has_null_restricted_static_fields)) {
>
>
> Was there a reason to group the last two restrictions?
They are equivalent expressions that were suggested offline.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2464#discussion_r3349810301
