On Tue, 2 Jun 2026 19:01:25 GMT, Dan Heidinga <[email protected]> wrote:
>> Matias Saavedra Silva has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Ioi comments
>
> src/hotspot/share/classfile/systemDictionaryShared.cpp line 305:
>
>> 303: // To ensure this, the types of the fields must be stored in the
>> archive along with
>> 304: // the field holder.
>> 305: if (k->has_inlined_fields()) {
>
> @fparain were you expecting to see an updated `if` statement with two
> conditions here?
>
>
> if (k->has_inlined_fields() || k->has_null_restricted_static_fields()) {...}
Yes, null restricted static fields must be in the candidate list along with the
inlined fields.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2464#discussion_r3349656479
