On Wed, 3 Jun 2026 22:33:00 GMT, Matias Saavedra Silva <[email protected]> 
wrote:

>> Classes can be excluded from the CDS archive for a variety of different 
>> reasons, such as having old classfile versions or being stored in a signed 
>> jar. These exclusions can extend to other classes that depend on an excluded 
>> class such as supers or interfaces.
>> 
>> Flat and null-restricted fields have layouts that are calculated when a 
>> classfile is parsed and they rely on the klass of the field being consistent 
>> between dumptime and runtime, thus adding a new dependency. This patch adds 
>> inline flat and null-restricted fields as new dependencies that may lead to 
>> the holding class being excluded from the CDS archive. Verified with a new 
>> test and tier 1-5 tests.
>> 
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Matias Saavedra Silva has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Include null-restricted static fields and added test

src/hotspot/share/classfile/classFileParser.hpp line 580:

> 578:   bool is_identity_class() const { return 
> _access_flags.is_identity_class(); }
> 579:   bool has_inlined_fields() const { return 
> _layout_info->_has_inlined_fields; }
> 580:   bool has_static_null_restricted_fields() const { return 
> _has_null_restricted_static_fields; }

Not called and flipped placement of "static".  Can we remove this function?

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2464#discussion_r3356608632

Reply via email to