On Fri, 12 Jun 2026 14:14:37 GMT, Matias Saavedra Silva <[email protected]> wrote:
>> This patch adds detailed printing for flat arrays in the AOTMapLogger and >> allows proper printing of embedded oops. Verified with tie 1-5 tests. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Matias Saavedra Silva has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 13 additional > commits since the last revision: > > - Improved printing of null fields > - Merge branch 'lworld' into print_oop_8383389 > - Ioi patch and added null marker printing > - Ioi comments and improved testing > - Added copyright > - Added test > - Merge branch 'lworld' into print_oop_8383389 > - Test improvement and cleanup > - Cleanup > - Shortcut for null fields > - ... and 3 more: > https://git.openjdk.org/valhalla/compare/cb07c413...b15612ae src/hotspot/share/cds/aotMapLogger.cpp line 880: > 878: case T_OBJECT: > 879: { > 880: if (fd->is_flat()) { Note that fd->is_flat() cannot be true with ft == T_ARRAY. src/hotspot/share/cds/aotMapLogger.cpp line 888: > 886: InlineLayoutInfo* li = > fd->field_holder()->inline_layout_info_adr(index); > 887: int nm_offset = li->null_marker_offset(); > 888: if (_fake_oop.raw_oop()->byte_field_acquire(nm_offset) == 0) > { It is recommended to use the method is_payload_marked_as_null() instead of checking the null marker value directly, to make the code robust against future changes of the null marker encoding, ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2444#discussion_r3413765631 PR Review Comment: https://git.openjdk.org/valhalla/pull/2444#discussion_r3413762530
