On Fri, 12 Jun 2026 14:14:37 GMT, Matias Saavedra Silva <[email protected]> wrote:
>> This patch adds detailed printing for flat arrays in the AOTMapLogger and >> allows proper printing of embedded oops. Verified with tie 1-5 tests. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Matias Saavedra Silva has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 13 additional > commits since the last revision: > > - Improved printing of null fields > - Merge branch 'lworld' into print_oop_8383389 > - Ioi patch and added null marker printing > - Ioi comments and improved testing > - Added copyright > - Added test > - Merge branch 'lworld' into print_oop_8383389 > - Test improvement and cleanup > - Cleanup > - Shortcut for null fields > - ... and 3 more: > https://git.openjdk.org/valhalla/compare/aa757869...b15612ae src/hotspot/share/cds/aotMapLogger.cpp line 1078: > 1076: st->print_cr(" - [null_marker] @%d %s", > 1077: nm_offset, > 1078: elm.raw_oop()->bool_field(nm_offset) ? "Field > marked as non-null" : "Field marked as null"); Same comment about testing the null marker. At this stage, the null-marker cannot indicate a null array element, because this case has been tested at line 1065 and would have trigger the execution of the `continue` statement. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2444#discussion_r3414023164
