On Fri, 12 Jun 2026 14:14:37 GMT, Matias Saavedra Silva <[email protected]> 
wrote:

>> This patch adds detailed printing for flat arrays in the AOTMapLogger and 
>> allows proper printing of embedded oops. Verified with tie 1-5 tests.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Matias Saavedra Silva has updated the pull request with a new target base due 
> to a merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains 13 additional 
> commits since the last revision:
> 
>  - Improved printing of null fields
>  - Merge branch 'lworld' into print_oop_8383389
>  - Ioi patch and added null marker printing
>  - Ioi comments and improved testing
>  - Added copyright
>  - Added test
>  - Merge branch 'lworld' into print_oop_8383389
>  - Test improvement and cleanup
>  - Cleanup
>  - Shortcut for null fields
>  - ... and 3 more: 
> https://git.openjdk.org/valhalla/compare/0923153c...b15612ae

src/hotspot/share/cds/aotMapLogger.cpp line 1065:

> 1063:       if (!real_klass->is_null_free_array_klass()) {
> 1064:         nm_offset = elem_k->null_marker_offset();
> 1065:         if (!elm.raw_oop()->bool_field(nm_offset)) {

It is recommended to use the method is_payload_marked_as_null() instead of 
checking the null marker value directly, to make the code robust against future 
changes of the null marker encoding,

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2444#discussion_r3413806409

Reply via email to