On Mon, 22 Jun 2026 15:36:35 GMT, Matias Saavedra Silva <[email protected]> 
wrote:

>> This patch adds detailed printing for flat arrays in the AOTMapLogger and 
>> allows proper printing of embedded oops. Verified with tier 1-5 tests.
>> 
>> New output looks like the following:
>> 
>> 0x00000000fff8d780: @@ Object (0xfff8d780) [Ljava.lang.Integer; length: 3
>>  - klass: 'java/lang/Integer'[] 0x0000000800160c00
>>  - Flat inline type element 'java/lang/Integer': - Index   0 offset  16:
>>    - private final value 'value' (fields 0x00000000) 'I' @8  43690 
>> (0x0000aaaa)
>>    - [null_marker] @12 Field marked as non-null
>>  - Flat inline type element 'java/lang/Integer': - Index   1 offset  24:
>>    - private final value 'value' (fields 0x00000000) 'I' @8  48059 
>> (0x0000bbbb)
>>    - [null_marker] @12 Field marked as non-null
>> - Flat inline type element 'java/lang/Integer': null
>>    - [null_marker] @13 Field marked as null
>> 
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Matias Saavedra Silva has updated the pull request with a new target base due 
> to a merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains 16 additional 
> commits since the last revision:
> 
>  - Merge branch 'lworld' into print_oop_8383389
>  - Logs null-free fields and improved AOTMapReader
>  - Merge branch 'lworld' into print_oop_8383389
>  - Improved printing of null fields
>  - Merge branch 'lworld' into print_oop_8383389
>  - Ioi patch and added null marker printing
>  - Ioi comments and improved testing
>  - Added copyright
>  - Added test
>  - Merge branch 'lworld' into print_oop_8383389
>  - ... and 6 more: 
> https://git.openjdk.org/valhalla/compare/fb94c627...755084cb

LGTM

-------------

Marked as reviewed by fparain (Committer).

PR Review: 
https://git.openjdk.org/valhalla/pull/2444#pullrequestreview-4562395716

Reply via email to