On Wed, 1 Jul 2026 18:15:05 GMT, Serguei Spitsyn <[email protected]> wrote:

>> src/hotspot/share/prims/jvmti.xml line 10718:
>> 
>>> 10716:           When preview features are enabled and this capability is 
>>> enabled, then
>>> 10717:           the following two events are enabled for value object 
>>> allocations:
>>> 10718:           <eventlink id="VMObjectAlloc"></eventlink>,
>> 
>> "then the following two events are enabled for value object allocations".  
>> This reads a bit like enabling can_support_value_objects will enable these 
>> two events. I think it would be better to say something like "events are 
>> sent for value objects when the following two events are enabled".
>
> Thank you for the catch and suggestion. Fixed now.

One other thing here: "can_support_value_objects" is a preview API. When we 
added can_support_virtual_threads in JDK 19 we added this to its description:


  <b> can_support_virtual_threads is a preview API of the Java platform. </b>
  <i>Preview features may be removed in a future release, or upgraded to
  permanent features of the Java platform.</i>

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2607#discussion_r3515230220

Reply via email to