Igor Lvovsky has posted comments on this change.
Change subject: Implement VMs live snapshots
......................................................................
Patch Set 10: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 1826: target = x.getElementsByTagName('target')
1. No, we are looking on all disks including cdrom:
<disk type='file' device='cdrom'>
<driver name='qemu' type='raw'/>
<source file='xxx.iso'/>
<target dev='hdc' bus='ide'/>
<readonly/>
<alias name='ide0-1-0'/>
<address type='drive' controller='0' bus='1' unit='0'/>
</disk>
the differences in 'device' attribute that we gather bellow.
2. OK, if you sure about it you have my ACK back.
Sorry about the noise
--
To view, visit http://gerrit.ovirt.org/469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id48a905938037eca2b1de966f4f83d801fdb9970
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
