Igor Lvovsky has posted comments on this change.
Change subject: Implement VMs live snapshots
......................................................................
Patch Set 10: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File vdsm/libvirtvm.py
Line 1826: target = x.getElementsByTagName('target')
Sorry missed it before.
we should initialize 'name', like name = ""
I know that for regular disk, target always exists, but I am not sure what
happens for example with empty cdrom
Line 1849: dev['name'] = name
maybe we need:
if name:
dev['name'] = name
Line 1858: 'name': name,
same as above, first build dictionary with or without name and append it after
this
--
To view, visit http://gerrit.ovirt.org/469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id48a905938037eca2b1de966f4f83d801fdb9970
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
