Federico Simoncelli has posted comments on this change.
Change subject: Implement VMs live snapshots
......................................................................
Patch Set 10: (1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 1826: target = x.getElementsByTagName('target')
1. Aren't we retrieving only the "disk" devices in line 1816? (the "cdrom"
devices shouldn't be present in disksxml)
2. The "cdrom" devices always have a target, and it doesn't matter if the cd is
present or not (just like any regular/real machine, the "hdc" device doesn't
appear only when you insert a cd)
--
To view, visit http://gerrit.ovirt.org/469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id48a905938037eca2b1de966f4f83d801fdb9970
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
