Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: vm payload: add file injection to vm
......................................................................
Patch Set 8: (7 inline comments)
....................................................
File vdsm/clientIF.py
Line 202: drive['specParams'].has_key('vmPayload'):
has_key is deprecated in favor of 'in':
'specParams' in drive and 'vmPayload' in drive['specParams']
....................................................
File vdsm/libvirtvm.py
Line 1978: drive['specParams'].has_key('vmPayload'):
Same here about has_key vs in.
....................................................
File vdsm/mkimage.py
Line 41: '''
Inconsistent indenting
Line 53: def _commonCleanFs(files, dirname, media):
Files seems to be an unused parameter.
Line 58: os.chown(media, uid, gid)
I would prefer you moved uid and gid assignments inside this if block. No need
to resolve them if you're not going to use them.
Line 82: os.rmdir(dirname)
Won't _commonCleanFs take care of this?
....................................................
File vdsm/supervdsmServer.py
Line 196: def removeFs(self, path):
Shouldn't this have a @logDecorator as well?
--
To view, visit http://gerrit.ovirt.org/2321
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I256475342c79690a95ad999335522f99714cdc8b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
