Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: vm payload: add file injection to vm ......................................................................
Patch Set 7: (1 inline comment) .................................................... File vdsm/constants.py.in Line 54: P_PAYLOAD_PREFIX = '/var/run/vdsm/payload/' In that case I still think /var/run is a bad place for these temporary files. If we look forward to the FHS 3.0 drafts (http://www.linuxbase.org/betaspecs/fhs/fhs/ch05s13.html): This directory was once intended for system information data describing the system since it was booted. These functions have been moved to /run; this directory exists to ensure compatibility with systems and software using an older version of this specification. Given Fedora is leading this change choosing /var/run now doesn't sound very future-proof. I think I still missed the problem with /tmp. mkdtemp will create the directory 700 so I fail to see the security aspect. -- To view, visit http://gerrit.ovirt.org/2321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I256475342c79690a95ad999335522f99714cdc8b Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
