Shahar Havivi has posted comments on this change. Change subject: vm payload: add file injection to vm ......................................................................
Patch Set 7: (4 inline comments) .................................................... File vdsm/mkimage.py Line 46: dirname = tempfile.mkdtemp(prefix=P_PAYLOAD_PREFIX) one of the guys rhev-h told me not to use /tmp/ for that for security reasons (in other patch) and /var/vdsm/.... is for vdsm user and its in var so its not survive boot, so what is the problem??? what race do you mean? Line 81: for file in os.listdir(dirname): in any case I must copy to the mounted point ie after mounting - this is true only to floppy device since in iso we use mkisofs which get a dir as a prameter. In floppy we first create the filesystem and mount it and copy files to it. I don't want to mount in _decodeFilesInDir() because it not common code (if you refer to that - which I think you didn't) Line 95: isopath = tempfile.NamedTemporaryFile(prefix=P_PAYLOAD_PREFIX, delete=False) what do you mean? prefix= is NamedTemporaryFile() parameter Line 103: _commonCleanFs(files, dirname, isopath) and what will I do in finally? I think this will "swallow" the error... -- To view, visit http://gerrit.ovirt.org/2321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I256475342c79690a95ad999335522f99714cdc8b Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
