Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: vm payload: add file injection to vm ......................................................................
Patch Set 7: (2 inline comments) .................................................... File vdsm/mkimage.py Line 95: isopath = tempfile.NamedTemporaryFile(prefix=P_PAYLOAD_PREFIX, delete=False) I think Dan suggested to use dir=P_PAYLOAD_PREFIX instead of prefix= and that might be better for most other prefix= uses in this file. Line 103: _commonCleanFs(files, dirname, isopath) I think you want a finally: here as well -- To view, visit http://gerrit.ovirt.org/2321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I256475342c79690a95ad999335522f99714cdc8b Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
