Eduardo has posted comments on this change. Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 6: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/storage/volume.py Line 450: if not sdCache.produce(self.sdUUID).hasVolumeLeases(): Do not produce the domain again please. Pass a setRO flag instead. There are 3 callers: 2 in image mod: _baseRawVolumeMerge() and _finalizeDestinationImage() There you already has the SD object and can check domain 3 there and pass the parameter. The 3rd call is from the Volume.clone() function. This call should be removed and setInternal() called from the [Block,File]Volume.create() where the domain object is already produced, check domain 3, and pass the setRO parameter. -- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
