Federico Simoncelli has posted comments on this change. Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 13: (1 inline comment) .................................................... File vdsm/storage/volume.py Line 464: def _legacySetRW(self, rwMode): To avoid another review cycle can you suggest a name for the method? Removing the _legacy prefix makes it _setRW which is too much generic (we already have several setrw methods). I was thinking of _setTypeRW (since it has to do with the volume type). Please add as many detail as you can to avoid another iteration. -- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
