Federico Simoncelli has posted comments on this change. Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 13: (2 inline comments) .................................................... File vdsm/storage/volume.py Line 464: def _legacySetRW(self, rwMode): The "deprecated" decorator is available only to hsm.py at the moment. Obviously it is possible to move it somewhere else and make it widely available but the legacy checks might be a little bit tricky to define if you want to make it reusable. For example you need a way to express where to get the data (sdUUID) and add the code that is capable to extract such information. Line 466: # permissions to read-only because it would interfere with the live I don't mind changing it but "eg" is listed as alternative form. -- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
