Ayal Baron has posted comments on this change. Change subject: Internal volumes must be RW in domain version 3 ......................................................................
Patch Set 9: I would prefer that you didn't submit this (4 inline comments) .................................................... File vdsm/storage/volume.py Line 450: if not sdCache.produce(self.sdUUID).hasVolumeLeases(): This has absolutely nothing to do with volumeLeases. This just has to do with it being incompatible with live snapshots (internal snapshot might still be in use by VM on non-spm host) Also, once we no longer support v2 domains it would be difficult to know that this piece of code is no longer relevant. Line 517: self.setrw(rw=True) this line would also be irrelevant in v3 domains, no? Line 520: # Look at setInternal for more information on this this looks exactly like setInternal, why not call it and have only 1 place that does this? Line 521: if not sdCache.produce(self.sdUUID).hasVolumeLeases(): again has nothing to do with volume leases -- To view, visit http://gerrit.ovirt.org/2786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fa99971390d3e26ff9c65cb883e1a369bd626d7 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
