Roman Fenkhuber has posted comments on this change.
Change subject: Basic tests for the tc module
......................................................................
Patch Set 2: (6 inline comments)
....................................................
File tests/tcTests.py
Line 25: from subprocess import Popen, check_output
Done. Replaced with check_call and Popen
Line 109: self.dev = dev
dev is the name of the device and is used in TestPortMirror. I will rename it
to devName.
Line 124: self.cloneDevice = open('/dev/net/tun', 'r+b')
Done
Line 152: sleep(1)
Done. I found a better solution.
Line 153: self.ping = Popen([EXT_PING, "-I",
Done
Line 157: sleep(1)
it indeed makes no sense. Removed.
--
To view, visit http://gerrit.ovirt.org/6225
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee9437d1b5a96b3896df157f13888485ae7292d2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Fenkhuber <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Roman Fenkhuber <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
