Roman Fenkhuber has posted comments on this change.

Change subject: Basic tests for the tc module
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File tests/tcTests.py
Line 173:         self.tap0.arpProxyFor("192.168.3.2")
You gave me this hint already when you gave me the task, but when I look into 
the function add_filter in tc.py it says 

    command = [EXT_TC, 'filter', 'add', 'dev', dev, 'parent',
                      parentId, 'protocol', 'ip', 'u32', 'match', 'u8', '0', 
'0',
                      'action', 'mirred', 'egress', 'mirror', 'dev', target].

So only IP packages are mirrored. I assumed, that this is the correct 
behaviour, but maybe " 'protocol', 'ip' " should be replaced with  " 
'protocol', 'all' "?

--
To view, visit http://gerrit.ovirt.org/6225
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee9437d1b5a96b3896df157f13888485ae7292d2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Fenkhuber <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Roman Fenkhuber <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to