Roman Fenkhuber has posted comments on this change.

Change subject: Basic tests for the tc module
......................................................................


Patch Set 3: (3 inline comments)

....................................................
File tests/tcTests.py
Line 83: def _listenOnDevice(fd):
Regarding the loop, I will find a better solution.

I will check if I need more than one read, but I think that I have to read the 
IGMP packets and so on too, to bring the device properly up.

Line 166:     tap0 = _Tap()
Done

Line 173:         self.tap0.arpProxyFor("192.168.3.2")
At least with newer kernel versions the bridge only becomes ready, when it is 
attached to an active device. When a device or a bridge is not ready nothing is 
mirrored by tc. At least this was my experience. So I decided to create a 
virtual device. It's not possible to add a tun device to a bridge, so it is a 
tap now. 

Since Kernel 2.6.32 a tap device only becomes ready when a process is attached 
to it. With the tap device ready, the bridge becomes ready and then mirroring 
works.

Please correct me if I am wrong.

--
To view, visit http://gerrit.ovirt.org/6225
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee9437d1b5a96b3896df157f13888485ae7292d2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Fenkhuber <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Roman Fenkhuber <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to